Title: [199940] trunk/Source/WebCore
- Revision
- 199940
- Author
- commit-qu...@webkit.org
- Date
- 2016-04-22 17:44:45 -0700 (Fri, 22 Apr 2016)
Log Message
Web Inspector: Include columnNumber in event listener locations
https://bugs.webkit.org/show_bug.cgi?id=156927
<rdar://problem/25884584>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-04-22
Reviewed by Brian Burg.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Include the column number in the location as well.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199939 => 199940)
--- trunk/Source/WebCore/ChangeLog 2016-04-23 00:40:43 UTC (rev 199939)
+++ trunk/Source/WebCore/ChangeLog 2016-04-23 00:44:45 UTC (rev 199940)
@@ -1,3 +1,15 @@
+2016-04-22 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Include columnNumber in event listener locations
+ https://bugs.webkit.org/show_bug.cgi?id=156927
+ <rdar://problem/25884584>
+
+ Reviewed by Brian Burg.
+
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForEventListener):
+ Include the column number in the location as well.
+
2016-04-22 Brent Fulgham <bfulg...@apple.com>
[Win] Unreviewed build fix.
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (199939 => 199940)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2016-04-23 00:40:43 UTC (rev 199939)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2016-04-23 00:44:45 UTC (rev 199940)
@@ -1466,6 +1466,7 @@
JSC::JSObject* handler = nullptr;
String body;
int lineNumber = 0;
+ int columnNumber = 0;
String scriptID;
String sourceName;
if (auto scriptListener = JSEventListener::cast(eventListener.get())) {
@@ -1478,6 +1479,7 @@
if (!function->isHostOrBuiltinFunction()) {
if (auto executable = function->jsExecutable()) {
lineNumber = executable->firstLine() - 1;
+ columnNumber = executable->startColumn() - 1;
scriptID = executable->sourceID() == JSC::SourceProvider::nullID ? emptyString() : String::number(executable->sourceID());
sourceName = executable->sourceURL();
}
@@ -1503,6 +1505,7 @@
.setScriptId(scriptID)
.setLineNumber(lineNumber)
.release();
+ location->setColumnNumber(columnNumber);
value->setLocation(WTFMove(location));
if (!sourceName.isEmpty())
value->setSourceName(sourceName);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
