So should defaultOptions be set to something sane or is nulls ok ? I think the real problem is the above screen resolution issue but I'm not sure about the interaction between screen scaling and the base font options. It seems to me we don't want to allow fonts to scale below a certain size ?
On a side note we should add get/setDefaultOptions and the above code should move into the webkit binding layer. Also the same for dpi I think it should be up in the app and we push the value down via get/setScreenResolution. This approach decouples the cairo/font code from gtk so it can be used for other ports. On Feb 13, 2008 3:27 AM, Alp Toker <[EMAIL PROTECTED]> wrote: > Christian Dywan wrote: > > > > While that might fix the problem, hardcoding arbitrary values is not > > exactly advisable. > > > > It should be interesting to figure out what causes this function to fail > > in the first place. > > > > The answer lies in the documentation for gdk_screen_get_resolution(): > > Returns: the current resolution, or -1 if no resolution has been set. > > So Sriram's patch is absolutely correct (coding-style issues aside). > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
