On 12-May-09, at 7:24 PM, Maciej Stachowiak wrote:
On May 12, 2009, at 3:58 PM, George Staikos wrote:
On 30-Mar-09, at 5:22 PM, Cameron Zwarich wrote:
For some time now there has been a bug in Bugzilla about adding
conditional support for ECMA Script Mobile Profile:
https://bugs.webkit.org/show_bug.cgi?id=24114
I am capable of reviewing the technical content of the patch, but
I don't know how the greater WebKit community feels about adding
support for ESMP and related technologies. To what extent do we
want support for them in the main WebKit tree?
6 weeks in and no opposition to this. Given that we just
rebased the patches against trunk again, and they've already gone
through many changes due to review, I'd like to start landing
them. Constantly adjusting them is growing tiring, and they do
not impact anything unless the macros are enabled.
I'm not a fan of these changes (I don't like divergence in core
behavior in the engine). But I think they are reasonable in light
of the proposed new way of thinking about ports as a set of policy
decisions, and leaving those decisions up to the port maintainers.
ENABLE(ESMP) is definitely a policy decision. Let's just make sure
we minimize impact on the normal code path and allow for reasonable
long-term maintainability.
Thanks Maciej. We wrote and rewrote this code many times over to
try to keep it clean. Yichao will be updating the bug reports with
new patches. I'll help review and land them but I really encourage
others to help review.
--
George Staikos
Torch Mobile Inc.
http://www.torchmobile.com/
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
