Thanks guys. One request - please write more comments in the code to clarify situations like this.
Toshi --- On Thu, 6/4/09, Darin Adler <[email protected]> wrote: From: Darin Adler <[email protected]> Subject: Re: [webkit-dev] cti_op_call_ArityCheck question To: "Toshiyasu Morita" <[email protected]> Cc: [email protected] Date: Thursday, June 4, 2009, 8:54 PM On Jun 4, 2009, at 1:50 PM, Toshiyasu Morita wrote: > I don't understand this code in JITStubs::cti_op_call_arityCheck(): > > ASSERT(argCount != newCodeBlock->m_numParameters); > > It's ensuring that the argument count does not equal the number of parameters > expected by the newCodeBlock. I could understand if it was ensuring the > argCount was the same, but why different? This slower code path must only be used when the number of parameters is not equal. If it was used when the number of parameters was equal, it would be a performance bug. -- Darin
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
