Agreed. That should just be a virtual call. I don't see any reason for that to need to be a bit on the baseclass. I do not think that changing ti to be a virtual call would cause a noticeable performance change.
-eric On Thu, Jun 18, 2009 at 7:29 PM, Roland Steiner<rolandstei...@google.com> wrote: > > Hi all, > > As I'll probably need to add some special handling for ruby in inline flow > boxes, I came across this flag InlineBox::m_isSVG. AFAICT it doesn't seem to > have a deep functionality (it seems to be always true for SVG boxes and > always false for non-SVG boxes). Now, in order to consolidate the code with > my intended changes, I wanted to replace this flag with a virtual function > call on InlineBox::isSVG(). > > However, before going ahead with this I wanted to ask whether I'm missing > something, or whether there are folks who are deeply attached to this bit > (for debugging purposes, perhaps?). > > Cheers, > > Roland > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
