[webkit-dev] possible wrong implementation visible_units.cpp@logicalStartOfLine

[tonikitoo (Antonio Gomes)]

Hi,

trying to understand this part of the webcore code, I faced a possibly
wrong impl:

(...)
VisiblePosition logicalStartOfLine(const VisiblePosition& c)
{
    VisiblePosition visPos = logicalStartPositionForLine(c);

    if (visPos.isNull())
        return c.honorEditableBoundaryAtOrAfter(visPos);

    return c.honorEditableBoundaryAtOrAfter(visPos);
}
(...)

note that  "c.honorEditableBoundaryAtOrAfter(visPos);"  will be
executed regardless visPos being null or not. thoughts ?

commit : r43032

-- 
--Antonio Gomes
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev