Darin Adler has been clear on his feelings about this: We also don't have agreement on whether to do something like [removing trailing whitespace] project-wide, and that's something I'd like to see before taking patches that just remove trailing whitespace. -- https://bugs.webkit.org/show_bug.cgi?id=25779#c2
fwiw, I know that the check-webkit-style checks for trailing whitespace (and I approved that change - sorry), but I think it should probably be removed. Dave On Wed, Aug 26, 2009 at 10:40 PM, Adam Barth <[email protected]> wrote: > After discussing this with Oliver, I realized that I misremembered > http://www.mail-archive.com/[email protected]/msg07720.html > as being more positive about style changes. > > Apologies, > Adam > > > On Wed, Aug 26, 2009 at 10:35 PM, Oliver Hunt<[email protected]> wrote: > > Adam just landed a fairly substantial patch that did nothing but remove > > whitespace from the ends of lines. While we had a thread about style > > changes earlier, it was in the context of changes that actually bring > code > > into line with style guidelines in a way that actually effects the > visible > > layout of code. > > > > I do not believe that patches such as r47808 should be considered > valuable > > as the changes have no visible effect on code layout, but do impact our > > ability to effectively use tools like svn or git blame, however the > > situation is slightly ambiguous on this matter so i thought i should > bring > > it up on the mailing list. > > > > Does anyone else have thoughts on this? > > > > --Oliver > > > > _______________________________________________ > > webkit-dev mailing list > > [email protected] > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
