On Oct 5, 2009, at 6:20 PM, Sam Weinig wrote:



On Mon, Oct 5, 2009 at 5:46 PM, Drew Wilson <atwil...@google.com> wrote:

I'm surprised to see these objections coming up now, weeks after the original discussion, and only after my patch has landed in the tree.

Sorry, I seemed to have missed that thread. I did however file a bug as soon as the first runtime switch went in.

That said, I agree that in an ideal world, we'd hide window.audio, shared workers, notifications, local storage, databases, session storage and any other runtime/platform-disabled API from enumerations - I just agree with Maciej that this isn't a hugely important issue, since these features are only runtime-disabled while under development and so not widely available anyway.

I obviously disagree with Maciej on this. I think it is bad to break developers expectations for feature detection.

My comments were specifically based on the Chrome team's plans to only have the runtime switch in "dev channel" builds, and always fully compile features out in release product. Seems to me like perfecting the behavior of feature detection in dev channel builds (their rough equivalent of WebKit nightlies) may not be worth the extra code complexity. If there is a relatively simple way to do it more correctly then we can go ahead and do that. I did point out the "in" testing flaw with the current state of affairs.

Regards,
Maciej

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to