http://trac.webkit.org/changeset/48525 was the first time I saw it.
On Thu, Oct 15, 2009 at 11:56 AM, Chris Marrin <[email protected]> wrote: > > On Oct 15, 2009, at 8:54 AM, Timothy Hatcher wrote: > >> This is rather ugly and does not match the majority of the code we have in >> WebCore already. > > I agree. I don't find any issues with the current, unindented style. I just > think that ifdefs that span more than 10 lines or so should always put the > condition on the #endif as a comment. > >> >> On Oct 15, 2009, at 8:12 AM, Eric Seidel wrote: >> >>> I really like the indented style that some folks have started using: >>> >>> #if foo >>> # define BAR BAZ >>> #else >>> # define BAR BARF >>> #endif >>> >>> I think we should standardize on something and add it to the style guides. >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ----- > ~Chris > [email protected] > > > > > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
