On 2009-10-18, at 17:02, Erik Arvidsson wrote: > On Sun, Oct 18, 2009 at 16:38, Mark Rowe <mr...@apple.com> wrote: > It looks like it could be useful, but it has a number of problems that would > make me wary of relying too heavily on it. > > For starters, the WebCore version is not exposed to web content at all so it > does not make sense to use WebCore's version number for this. The WebKit > version would be a more appropriate number to use. > > How is the WebKit version determined? I was told that the WebCore version was > the same.
Each of the projects has its own version number. They're typically identical, but there's no guarantee that is the case. The version exposed in the user agent string is always taken from the WebKit project, never WebCore. > > It also presents misleading results. It can report changes as being > available much later than they actually were, such as in the case of r45979 > which it reports as being fixed in 532.1 when in reality this fix first > shipped as part of Safari 4.0.3 in WebKit x531.6. This could pose problems > if the results of the tool are used for workarounds in situations where the > fix causes the workaround to not function as expected. > > You are correct. This tool only keeps track of when the build number changes > due to changes in Version.xcconfig. I should add a comment about that in the > description. I'm not sure what you're saying here or how it relates to what I said. The WebKit version number is always taken from WebKit's Version.xcconfig. > > A worse case is when the tool reports issues as being fixed earlier than they > actually were, as is the case with r45712. The tool reports this as being > fixed in 531.5 when in reality that version does not contain that fix. > > How does that happen? 531.5 was set at r45738. The point at which the version number changed on trunk isn't what is interesting. It's the point at which the tag for that version is created that is interesting. - Mark
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
