For (2), are we sure the relevant diff tools can isolate the real
changes to those files amid mass indentation? Most if not all can,
but I don't know about the automatic diffs that may be part of the
webkit build/release/publish process. Not that this is a deal-breaker,
but I wanted to bring it up.
On Dec 1, 2009, at 12:52 PM, David Hyatt wrote:
(2).
On Dec 1, 2009, at 2:42 PM, Adam Barth wrote:
A common "false positive" in the style-queue is as follows:
Code inside a namespace should not be indented. [whitespace/indent]
[4]
That's because the namespace indent rule is fairly new and its hard
to
fix without touching the whole file. I don't think the style-queue
should be spamming bugs with non-actionable information. There seem
to be a few choices:
1) Disable this warning because it's not helpful at the moment.
2) Change our code to comply with this style rule (e.g., as we touch
files, fix them so that the warning doesn't occur).
3) Change our style guide to match our code.
Personally, I'm in favor of (2) because it seems silly to have a rule
in our style guide with which we never plan to actually comply.
Thoughts?
Adam
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
