On Mar 1, 2010, at 6:46 PM, Ojan Vafai wrote:
On Mon, Mar 1, 2010 at 6:40 PM, Maciej Stachowiak <m...@apple.com>
wrote:
On the one hand, it's good to shift the default. On the other hand,
many render tree dumping tests do not currently need to run any
JavaScript script, while many text-only tests do. I would almost
suggest having a per-directory default but that might be too
confusing and mysterious.
Yeah, I thought about having per-directory defaults too. There are
some nice things about that. For example, the editing tests mostly
want something in between dumpAsText and a render dump. It would be
great if we could default those to dumpAsMarkup (https://bugs.webkit.org/show_bug.cgi?id=26501
).
<3 dumpAsMarkup
But, I agree, it's probably too confusing.
Question: are text-only tests really faster, in non-pixel mode? I
would be surprised if there was a significant different, and it may
point to something we can optimize.
I just meant that they are faster assuming you're running pixel
tests. Ideally we'd head in the direction of running pixel tests by
default one day. :)
Good point. If we always ran the pixel tests, then perhaps we should
consider having some tests that dump the render tree but are not
subject to pixel testing. I do think the platform-independence issue
is a good reason to be strongly biased towards making new tests dump
as text (or dump as markup, once that is added). Even if we do not
change the default, we should recommend it as a good practice and
reviewers should be on the lookout for this issue when reviewing
patches.
Cheers,
Maciej
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
