On Tue, Mar 9, 2010 at 11:45 AM, Adam Barth <aba...@webkit.org> wrote:
> Q: Why are you doing this? You should stick to reviewing code in your own > area. > A: The pending-review queue is out of control. It's past the tipping > point where there are too many patches for someone to reasonably look > at the queue. It's not healthy for the project to leave patches > unreviewed for over a month. Someone needs to step up. If not me, > then who? > <snip> > If you're a reviewer, I'd encourage you to work through pending-review > from oldest to newest. Don't be afraid of r-ing a patch. Believe me, > folks are thankful for feedback (even negative feedback) when their > patches have been sitting around collecting dust. > Also, it's OK to comment on a patch with a suggestion as to how to make it more easily reviewable. As an example, Eric noted on this patch of mine ( https://bugs.webkit.org/show_bug.cgi?id=35314) that most of the layout test changes could be committed as a separate patch before making any code changes and that would make verifying correctness of the code changes easier. While it was probably more work for me, I appreciated the opportunity to make progress instead of just stalling. Ojan
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev