I would be against changing our guide to discourage spaces. It's easy (and good practice) to code for handling paths with spaces. Even if we discourage spaces in webkit itself, people who checkout webkit in a path with spaces in it would still be screwed.
-eric On Mon, Mar 22, 2010 at 10:24 PM, Chris Jerdonek <cjerdo...@webkit.org> wrote: > I was wondering if there are any reasons we would ever need files in > our repository whose file names contain spaces. The reason is that it > makes shell commands slightly trickier to write (e.g. using the bash > shell). > > I found that we currently have these files whose file names have spaces: > >> find . -wholename '* *' \! \( -wholename '*.svn*' -or -wholename >> "*/WebKitBuild/*" \) > > ./LayoutTests/fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html > ./LayoutTests/http/tests/misc/resources/a success.html > ./PageLoadTests/svg/files/42450-under the see.svg > ./PageLoadTests/svg/files/44057-drops on a blade.svg > ./WebCore/manual-tests/inspector/errors-with-space in-url.html > ./WebKitSite/demos/transitions-and-transforms/Finder Coverflow.png > ./WebKitSite/demos/transitions-and-transforms/Mail Stationery.png > ./WebKitSite/demos/transitions-and-transforms/Quick Look.png > ./WebKitSite/demos/transitions-and-transforms/Time Machine.png > ./WebKitTools/DumpRenderTree/fonts/WebKit Layout Tests 2.ttf > ./WebKitTools/DumpRenderTree/fonts/WebKit Layout Tests.ttf > > Can we make it a part of our style guide that file names shouldn't have > spaces? > > Thanks, > --Chris > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
