Hi there, Yes, the patch got bit rotten a few times and due to our release of Qt 4.6 we ended up abandoned it.
We are still interested in it though, other things just came up with higher priority. Cheers, Kenneth On Mon, May 31, 2010 at 9:17 PM, Kevin Ollivier <[email protected]> wrote: > Hi Kenneth, > > On May 31, 2010, at 11:09 AM, Kenneth Christiansen wrote: > >> Hi Kevin, >> >> They export privately using some files listing the symbols to be >> exported (mac supports that as so does visual studio, I believe). We >> cannot do this for Qt, so if you search bugzilla you will find that we >> have some old patches adding export declarations to the classes being >> exported (or the individual symbols, if that made more sense) > > So what's the status on that? From the bug tracker link Ossy sent, it looks > like the patch never made it through review, and eventually had the review > bit unset because of code rot. Are you guys patching a git branch or > something? > > Thanks, > > Kevin > >> Cheers, >> Kenneth >> >> On Mon, May 31, 2010 at 3:03 PM, Kevin Ollivier <[email protected]> >> wrote: >>> Hi all, >>> >>> I'm trying to switch over to building JavaScriptCore as a shared library >>> for the wx port, but one issue I'm hitting is the issue of export symbols. >>> I was wondering how other ports handle this? I know Apple / Win and Apple / >>> Mac have export symbol files, but I'd like to avoid manually creating and >>> maintaining such files, and at the same time, using the Apple / Win and >>> Apple / Mac files seems like it will require a number of adjustments to my >>> build process to get working. (e.g. it wants symbols specific to those >>> ports) So I'm wondering, what are my options here? Would it be acceptable >>> to start adding JS_EXPORT to functions in the JSCore library that are >>> needed by DRT, etc.? >>> >>> Thanks, >>> >>> Kevin >>> _______________________________________________ >>> webkit-dev mailing list >>> [email protected] >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >> >> >> >> -- >> Kenneth Rohde Christiansen >> Technical Lead / Senior Software Engineer >> Qt Labs Americas, Nokia Technology Institute, INdT >> Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org > > -- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
