If you're tired of my complaining about the tree being red, you can skip this message.
Today Alexey checked in <http://trac.webkit.org/changeset/62576>, which broke two tests on every port. 12 hours later, these failures remained in the tree until I cleaned them up. This mess could have been avoided in a number of ways: 1) He could have run-webkit-tests before committing his change. 2) If he didn't have time to run the tests locally, he could have used the commit-queue to run-webkit-tests before it landed his patch. 3) He could have looked at the tree when sheriff-bot informed him that he might have broken Leopard Intel Debug by pinging him in #webkit and commenting on his bug: <https://bugs.webkit.org/show_bug.cgi?id=41156#c8>. Is this acceptable behavior? http://webkit.org/coding/contributing.html clearly says to "run the layout tests using the run-webkit-tests script and make sure they all pass." That page also says: [[ In either case, your responsibility for the patch does not end with the patch landing in the tree. There may be regressions from your change or additional feedback from reviewers after the patch has landed. You can watch the tree at build.webkit.org to make sure your patch builds and passes tests on all platforms. It is your responsibility to be available should regressions arise and to respond to additional feedback that happens after a check-in. ]] Are there consequences for breaking these rules? Adam _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
