Given a patch file, you have its line number ranges. Given a git checkout, you can very quickly find who has made changes to what lines in that file.
You then can have a bot post to the bug, saying that 10 people have touched the lines you're touching in your patch. 3 of them are active reviewers, here are their names: You could even educate such a script/bot about "whitespace" or "rename" changes so they're excluded from any "who touched this" lookup. I would like to build (or see built) this (or a similar) script. I just haven't had the time to do it. It's better than manual owner files or watch lists IMO because it's automatically generated. -eric On Fri, Jul 23, 2010 at 8:04 AM, Alex Milowski <[email protected]> wrote: > On Fri, Jul 23, 2010 at 12:51 PM, Eric Seidel <[email protected]> wrote: >> I've never really liked trac.webkit.org/wiki/WebKit%20Team. Its >> always seemed more of place to brag about webkit involvement, than a >> useful reference. I think we could build a much better "who should I >> ask to review this" tool based on SVN information. > > Were you thinking of some kind of automated "harvesting" of this information? > > I seems like a simple data file that can be processed by systems > would be a good way to start. Then people can submit patches (or > commit changes) to file changing the areas that they are willing > to review and others can see/review that commitment. > > People who are looking for a reviewer can look through that file for > individuals. > > If a review doesn't want to get reminder e-mails or requests from > systems or individuals, they would then have to remove that > review "area" for themselves from that data file. > > I would personally use an XML format ... but that's me. ;) > > > -- > --Alex Milowski > "The excellence of grammar as a guide is proportional to the paucity of the > inflexions, i.e. to the degree of analysis effected by the language > considered." > > Bertrand Russell in a footnote of Principles of Mathematics > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
