Sorry. I should really have made better comments. This code is not used yet, I just aded it yesterday and plan to use it soon. The assertion, that I have introduced, was wrong because the case callType == CallTypeNone must be handled.
It is not about correcting existing problems because I just introduced this code. It will not cause any regressions because the code that will use it did not land yet, it is in review process. I am sorry if I made you spend your time. Next time please contact me, it is easy to find me. I have been working actively in webkit for a while, I am always in iRC (lca), my name, email and IRC user can be found in http://trac.webkit.org/wiki/WebKit%20Team and I am willing to help, answer, change or whatever is needed. And of course I would reply to any comment in the bug. Luiz 2010/9/23 Alexey Proskuryakov <[email protected]> > > It is unfortunate that this fix changes unused code. Will it be covered by > existing layout tests when ScriptFunctionCall and ScriptCallback start being > used? > > The patch and bug were highly confusing. Without any explanation of why > this assertion was wrong, a test case, or an explanation of why one can't be > made, I had to spend considerable time figuring out why it shouldn't be > rolled out immediately. > > - WBR, Alexey Proskuryakov > > Начало переадресованного сообщения: > > *От: *[email protected] > *Дата: *23 сентября 2010 г. 8:57:01 Тихоокеанское летнее время > *Кому: *[email protected] > *Тема: **[webkit-changes] [68146] trunk/WebCore* > > Revision 68146 <http://trac.webkit.org/projects/webkit/changeset/68146> > Author [email protected] Date 2010-09-23 08:56:59 -0700 (Thu, 23 Sep > 2010) Log Message > > 2010-09-23 Luiz Agostini <[email protected]> > > Reviewed by Andreas Kling. > > Invalid assertion in ScriptCallback > https://bugs.webkit.org/show_bug.cgi?id=46348 > > Removing invalid ASSERT from method ScriptCallback::call(). > > * bindings/js/ScriptFunctionCall.cpp: > (WebCore::ScriptCallback::call): > > Modified Paths > > - trunk/WebCore/ChangeLog > - trunk/WebCore/bindings/js/ScriptFunctionCall.cpp > > Diff > Modified: trunk/WebCore/ChangeLog (68145 => 68146) > > --- trunk/WebCore/ChangeLog 2010-09-23 15:51:41 UTC (rev 68145) > +++ trunk/WebCore/ChangeLog 2010-09-23 15:56:59 UTC (rev 68146)@@ -1,3 > +1,15 @@+2010-09-23 Luiz Agostini <[email protected]> > + > + Reviewed by Andreas Kling. > + > + Invalid assertion in ScriptCallback > + https://bugs.webkit.org/show_bug.cgi?id=46348 > + > + Removing invalid ASSERT from method ScriptCallback::call(). > + > + * bindings/js/ScriptFunctionCall.cpp: > + (WebCore::ScriptCallback::call): > + 2010-09-23 Martin Robinson <[email protected]> Reviewed by > Ariya Hidayat. > > Modified: trunk/WebCore/bindings/js/ScriptFunctionCall.cpp (68145 => > 68146) > > --- trunk/WebCore/bindings/js/ScriptFunctionCall.cpp 2010-09-23 15:51:41 UTC > (rev 68145) > +++ trunk/WebCore/bindings/js/ScriptFunctionCall.cpp 2010-09-23 15:56:59 UTC > (rev 68146)@@ -215,9 +215,9 @@ CallData callData; CallType callType > = getCallData(m_function.jsValue(), callData);+ if (callType == > CallTypeNone) > + return ScriptValue(); - ASSERT(callType != CallTypeNone); > - JSValue result = JSC::call(m_exec, m_function.jsValue(), callType, > callData, m_function.jsValue(), m_arguments); hadException = > m_exec->hadException(); > > _______________________________________________ > webkit-changes mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes > > > >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
