Yeah, the problem with that is:
def fetch_patches_from_pending_commit_list(self):
return sum([self._fetch_bug(bug_id).reviewed_patches()
for bug_id in self.fetch_bug_ids_from_pending_commit_list()], [])
which means each EWS bot is going to poll ~90 bugs every 2 minutes.
For each bug, it's going to hit the bug page and the attachment page
for a total of 16 queries per second...
IMHO, we're better off moving the list of patches to process to
AppEngine. In that model, we'll have one query every thirty seconds
on bugs.webkit.org for the whole EWS, no matter how many bots we have.
Adam
On Fri, Sep 24, 2010 at 11:44 AM, Eric Seidel <e...@webkit.org> wrote:
> On Fri, Sep 24, 2010 at 11:42 AM, Eric Seidel <esei...@google.com> wrote:
>> https://bugs.webkit.org/show_bug.cgi?id=35460
>>
>> On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler <da...@apple.com> wrote:
>>> It’s not great that if I review a patch that means it won’t get EWS
>>> results. Maybe the EWS could be changed to test out “review+” patches once
>>> it gets done with all the “review?” patches?
>>>
>>> Is that practical?
>>>
>>> -- Darin
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
