On Oct 12, 2010, at 11:47 PM, Adam Barth wrote: > Hi webkit-dev, > > I'd like to gauge interest in the WTFURL work [1]. Currently, there > are two WTFURL patches that have been up for review for over a month > without a single comment: > > https://bugs.webkit.org/show_bug.cgi?id=45085 > https://bugs.webkit.org/show_bug.cgi?id=45088 > > That leads me to believe this work is not desired by the project.
Reviewed both. I didn't know that you'd returned to this project or that you had patches pending. All you had to do was ask. > 1) I recruit folks to review the patches. To date, I've been waiting > for Apple folks to review these patches on the theory that they might > like to have input on this topic. If that's not necessary/desirable, > I can expand my reviewer recruitment. Asking people directly tends to work well. > > 2) I can spam the review queue with all the WTFURL patches so that > reviewer can see how the whole thing is going to work. Typically, we > advise folks to land things like this in small, buildable chunks, > which is what I've been doing. However, if there's a month latency > between chunks, that means the project will never be finished. It is kind of hard to review the pieces without context or tests. I assume correctness issues will be flushed out later through comprehensive testing. And I can spot surface-level style issues reviewing one patch at a time. But it's hard to evaluate the design of the code without understanding the big picture. Maybe that is better done once enough code is landed that it works. > > [1] By way of background, Chromium uses a different URL parsing > library than other WebKit ports. In the interests of not fracturing > the WebKit platform, I've been working on implementing a URL parsing > library, called WTFURL, that meets the needs of both the WebKit and > Chromium projects. I support your goals for this project. Regards, Maciej _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev