On 2011-03-03, at 23:58, Ojan Vafai wrote: > This isn't a big deal either way, but I noticed that > http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit > lists the following as the process for unreviewed commits: "Unreviewed > commits should include a line saying "Unreviewed." in place of the "Reviewed > By..." line in each ChangeLog entry." > > The "Unreviewed" bit is news to me. I thought it was assumed that if there's > no "Reviewed By..." line then it was committed unreviewed and, in fact, that > was preferred to adding the "Unreviewed" line.
It's never been customary to say "Unreviewed." in place of a reviewer. The most common type of change that doesn't require review is a build fix, and in those cases it's customary to omit the reviewer line completely. <http://trac.webkit.org/search?q=build+fix> provides plenty of examples of this. The wiki page should be updated to match existing procedures. - Mark _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
