On Apr 21, 2011, at 4:47 PM, Ojan Vafai wrote: > Thanks for the quick feedback. > > On Thu, Apr 21, 2011 at 4:21 PM, Maciej Stachowiak <[email protected]> wrote: > (1) Takes two lines per entry unless you make your window ridiculously wide. > This makes it hard to scan. > > I'll make it whitespace:nowrap. That will mean the right side might get cut > off, but I think that's fine.
I'll take a look once there is a demo version. > > (2) Slow to load (apparently it loads a 3 meg JSON file before displaying > anything?) > > Loading it locally is very fast for me. I guess I should try it on a laptop > though. I'm on a laptop. On my home WiFi, it takes 5-15 seconds. This old-style results page takes less than 200ms, uncached: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r84598%20(28450)/results.html > For context, we reuse the JSON file that's used for the test runtime > treemaps, which means we need an entry for each test. That json will will get > .5 meg smaller shortly. There are a number of approaches to make this smaller > if needed. Some options would be to generate a separate JSON file, or to make > the data format in the existing json file more compact. It seems to me that only data on unexpected failures should be needed for initial display. Making the page load fast seems more important than convenience of reusing an existing JSON file. I hope you will agree that 5-15 second load time is not acceptable. I'm sure it would be even worse in poor network conditions, where even the old-style pages can be a challenge to load. I would also like to be able to look at results pages on my iPhone or iPad without invoking the OOM killer. > > (3) I like PrettyPatch format better than wdiff format. > > This is orthogonal. new-run-webkit-tests will use whichever one is available > on the system. The results.html file will display whichever one was used. What would the bots display if this is deployed? Regards, Maciej
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
