I would go so far as to suggest removing both Diff and Formatted Diff. I guess I'm more excited about removing Formatted Diff than I am Diff, since Diff actually has some built in bugzilla crazy features (like diffing between attachments!?!) but Formatted Dfif is just a lame version of Review Patch. It would be easy to add a "just show me the damn diff" button (or hashtag) to Review Patch to have Formatted Diff functionality if people need it.
+1 for removing the "preview" button. I only ever click it by accident. On Sun, Jun 12, 2011 at 1:30 PM, Adam Barth <[email protected]> wrote: > The following text appears next to every patch in bugs.webkit.org: > > Review Patch | Details | Formatted Diff | Diff > > Does anyone click the "Diff" link? I clicked by accident the other > day and my eyes were scared. Should we remove it? > > Similarly, the Review Patch page has these buttons on the bottom: > > Bug 62XXX (contributor) r: ? cq: ? [Preview] [Publish] > > Does anyone click the "Preview" button? If not, we should probably remove it. > > Thanks! > Adam > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
