You should also feel welcome to land test suites which entirely/mostly fail, and then later land the code changes which make them pass. We used this method with great success for the HTML parser re-write. This can be useful in cases where your individual tests have larger coverage than any individual change.
-eric On Fri, Jun 17, 2011 at 1:58 AM, Mihnea-Vlad Ovidenie <[email protected]> wrote: > Hello, > > Part of our efforts towards enabling CSSRegions/CSSExclusions support in > WebKit, we have submitted 2 patches last week: > [61726][CSSExclusions]Parse wrap shape property > [61730][CSSRegions]Parse flow property > > In addition to these patches, we would like to prepare more patches. > However, we feel a little stuck because we want to make sure that the code > and the associated tests we submitted with the first patches are going in > the right direction. > > Specifically, for the addition of new CSS properties, is there a template > we should follow for parsing and testing? We have seen some patterns for > handling properties > and we are not sure which one to follow. > > This is important because we would like to start working on support for > additional properties, and avoid repeating the same mistakes if there are > any in these initial patches. > > Thanks in advance for your help! > Cheers, > Mihnea > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
