On Mon, Jun 27, 2011 at 15:36, Ojan Vafai <[email protected]> wrote: > On Mon, Jun 27, 2011 at 3:17 PM, Alexey Proskuryakov <[email protected]> wrote: >> >> 27.06.2011, в 14:03, Darin Fisher написал(а): >> > I think we can make this behavior a Setting, and then certainly each >> > embedder of WebKit >> > can decide how prominently to surface this option. For Chrome, we'll >> > probably either make >> > it be a command line flag, or we would just leave out the option >> > entirely. >> >> Perhaps I'd be less unhappy about this change if the flag were off in >> layout tests, so that we didn't have to change them all to remove alert() in >> unload. > > That patch was scrapped. Now alerts during unload handlers will just log to > the console, so the alerts can be left in. The expected results for the > tests will change a bit though since the message being logged is different.
Right. In addition, the proposed patch only enables this for chromium, so other ports are not affected. Can I get a review? http://webkit.org/b/56397 _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
