Update: https://bugs.webkit.org/show_bug.cgi?id=80497 has a patch up. Would appreciate a once-over from port maintainers. It defines an additional variable, with values the same as that of ENABLE_NOTIFICATIONS.
Jon On Mar 6, 2012, at 10:00 PM, Maciej Stachowiak <m...@apple.com> wrote: > > On Mar 6, 2012, at 9:00 PM, Jon Lee wrote: > >> Whoops, I forgot to mention this also: >> >> I would like to add a new ENABLE(LEGACY_NOTIFICATION_DEPRECATION) flag which >> allows ports to deprecate the legacy API. This saves us from the hazards of >> refactoring the code to use a different ENABLE flag for the legacy API, and >> allows ports to opt-in when they're ready. Does this sound good? > > It's thoughtful to do it that way, but I think we should stick with the > standard approach of ENABLE flags enabling features, instead of disabling > them. So ENABLE(LEGACY_NOTIFICATIONS) and we can default it to on for ports > that already had ENABLE(NOTIFICATIONS) historically. > > Regards, > Maciej > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
