Okay, thanks for the clarification. Given that the blackberry was the only port that listed this flag in the list of features, I think it's okay to remove this flag.
As I mentioned earlier, the flag is pretty self-contained, so if this removal causes any inconvenience, we can always revert it later. i.e. I've r+ed Benjamin's patch. - Ryosuke On Thu, Apr 5, 2012 at 8:01 PM, Jeff Rogers <[email protected]> wrote: > The BlackBerry port doesn't use that flag, we are fine with removing it. > > On Thu, Apr 5, 2012 at 8:34 PM, Ryosuke Niwa <[email protected]> wrote: > >> On Thu, Apr 5, 2012 at 4:35 PM, Benjamin Poulain <[email protected]>wrote: >> >>> On Thu, Mar 29, 2012 at 3:00 PM, Benjamin Poulain <[email protected]> >>> wrote: >>> > I could not find any case where PREEMPT_GEOLOCATION_PERMISSION is not >>> > used. Unless someone does not use this flag, I plan to remove the flag >>> > and the related useless code. >>> >>> I did not get any answer for a week. Here is the patch to clean the >>> flag: https://bugs.webkit.org/show_bug.cgi?id=83325 >> >> >> Maybe blackberry port uses it? >> >> - Ryosuke >> >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
