[From the correct email] On Mon, Apr 9, 2012 at 12:26 PM, Jarred Nicholls <jar...@sencha.com> wrote:
> On Mon, Apr 9, 2012 at 12:18 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > >> We have discussed this before: >> https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html >> >> A better change would be for us to generate the diff on EWS, and get rid >> of binding tests step from build bots since they aren't really testing >> anything. The primary use case of run-bindings-tests is to see the diff >> before/after a code generator change and it has no business running on the >> bot or in check-webkit-style. >> > > Either way, we concluded that running the binding tests is very quick and > cheap, so wherever it is still effective to prevent regressions in code > generation is fine by me; on an as-needed basis (EWS) is clearly ideal, > rather than on all builds. > > >> >> - Ryosuke >> >> On Mon, Apr 9, 2012 at 6:39 AM, Vineet Chaudhary <rgf...@motorola.com>wrote: >> >>> Hi All, >>> >>> >>> It is observed that if changes are made in Codegenerator*.pm we need to >>> rebase results of run-bindings-tests. >>> >>> Many times authors forgot to update these binding results. >>> >>> >>> IMO we should add check in ./check-webkit-style to warn/(give a chance) >>> author to run run-bindings-tests if Codegenerator is modified. >>> >>> I have filed bug for this https://bugs.webkit.org/show_bug.cgi?id=83354. >>> >>> >>> Please let me know if any suggestions to make this change. >>> >>> Thanks, >>> Vineet >>> >>> >>> _______________________________________________ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >>> >> >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> > > > -- > ................................................................ > > *Sencha* > Jarred Nicholls, Senior Software Architect > @jarrednicholls > <http://twitter.com/jarrednicholls> > >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
