I noticed a number of patches going in recently that add null checks, or 
refactor the code under the premise of "eliminating potential null 
dereference". What does that mean, and why are we allowing such patches to be 
landed?

For example, this change doesn't look nice: 
<http://trac.webkit.org/changeset/114678/trunk/Source/WebCore/css/CSSStyleSelector.cpp>.
 We should not try to confuse ourselves with unusual for loop forms, and there 
is no explanation at all of why these changes are needed. No regression tests 
either.

- WBR, Alexey Proskuryakov

_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to