On Fri, Apr 20, 2012 at 1:48 PM, Rachel Blum <[email protected]> wrote: > Unless there's a demonstrable reason that you _need_ a value uninitialized, > why is the burden of proof on the person doing cleanup? Yes, at the point > the code was written, it's well possible that the author was aware that the > value would always be initialized for use. However, if code is added to a > class, that invariant is not always checked again.
Unless totally trivial, a patch doing a "cleanup" is no different than a patch adding a feature or fixing a bug. You should demonstrate your change is correct. The patch might be great, or it might be bad and blindly following a tool. You show it is correct by adding tests or having a good Changelog. Benjamin _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
