Skip to site navigation (Press enter)
Re: [webkit-dev] Feature Announcement: Adding
</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-dev@lists.webkit.org&q=from:%22Eric+Seidel%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Eric Seidel</span></span></a></span> <span class="date"><a href="/search?l=webkit-dev@lists.webkit.org&q=date:20120501" rel="nofollow">Tue, 01 May 2012 12:20:17 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre>Work is complete, fully working. Passing all the tests I could come up with: <a rel="nofollow" href="https://github.com/eseidel/webkit/compare/master...seamless">https://github.com/eseidel/webkit/compare/master...seamless</a></pre><pre> I'm uploading and landing patches once reviewed again in bugzilla. I do not plan to add an ENABLE, as this work is complete and will all be landed by end of week, assuming timely reviews. -eric On Sun, Apr 1, 2012 at 4:28 PM, Eric Seidel <e...@webkit.org> wrote: > Adding ENABLE, skipping tests, and reverting any non-passing tests, > proved complicated. So I've reverted my work on trunk: > <a rel="nofollow" href="http://trac.webkit.org/changeset/112820">http://trac.webkit.org/changeset/112820</a> > > and I'll be doing my <iframe seamless> work on GitHub. Interested > parties can follow my fork/branch here: > <a rel="nofollow" href="https://github.com/eseidel/webkit/compare/master...seamless">https://github.com/eseidel/webkit/compare/master...seamless</a> > > Thank you all for your feedback. > > -eric > > On Fri, Mar 30, 2012 at 8:11 PM, Darin Fisher <da...@chromium.org> wrote: >> [Oops, I meant to reply on list.] >> >> I think it is a risky practice for WebKit to have half-baked "webkit" >> prefixed >> features enabled by default on trunk. It puts the burden on all WebKit >> ports >> to know which features are half-baked, whereas individual authors of new >> features would know best how stable their features are. >> >> Once a port ships a feature, however baked the feature may be, if it becomes >> popular (to some degree), we risk having to support it. I don't think web >> developers necessarily understand that they should regard "webkit" prefixed >> features as buyer-beware given that there are so many "webkit" prefixed >> features that we all tell developers to use. How can developers tell the >> difference between the stable ones and unstable ones? >> >> It seems safest to ENABLE-guard all half-baked features on trunk, vendor >> prefixed or otherwise. The only reason to vendor prefix is if there is not >> a >> stable well established spec with multi-vendor support. In the case of >> <iframe seamless>, which seems quite well specified as part of HTML5, >> perhaps there is no need to vendor prefix at all? Just hide behind a guard >> until it is ready? >> >> -Darin >> >> >> On Fri, Mar 30, 2012 at 6:34 PM, Eric Seidel <e...@webkit.org> wrote: >>> >>> We certainly could add an ENABLE. My impression is that we have many >>> half-baked -webkit- features, and that use there-of is buyer-beware >>> anyway? >>> >>> My expectation is that this may be a rather short implementation >>> effort. Ideally I'd be able to finish it next week. Maybe we should >>> revisit this question next Friday? >>> >>> (It's also probably better to discuss this on webkit-dev, but I didn't >>> know if you had intended this email as private.) >>> >>> -eric >>> >>> On Fri, Mar 30, 2012 at 4:59 PM, Darin Fisher <da...@chromium.org> wrote: >>> > >>> > >>> > On Fri, Mar 30, 2012 at 4:01 PM, Eric Seidel <e...@webkit.org> wrote: >>> >> >>> >> Per <a rel="nofollow" href="http://www.webkit.org/coding/adding-features.html">http://www.webkit.org/coding/adding-features.html</a> >>> >> >>> >> >>> >> I'm working on adding <iframe seamless> support to WebKit. >>> >> <a rel="nofollow" href="http://www.whatwg.org/specs/web-apps/current-work/#dom-iframe-seamless">http://www.whatwg.org/specs/web-apps/current-work/#dom-iframe-seamless</a> >>> >> >>> >> Folks interested can follow along at home: >>> >> <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=45950">https://bugs.webkit.org/show_bug.cgi?id=45950</a> >>> >> >>> >> It's currently accessible only via <iframe webkitseamless> / >>> >> iframe.webkitseamless, but once the implementation is complete it will >>> >> move to its spec name "seamless". I have no plans to add a feature >>> >> define, as it should be on for all ports. >>> > >>> > >>> > Wouldn't it be better to hide the feature from shipping products until >>> > it is >>> > complete? >>> > >>> > I realize this complicates testing, but it seems problematic to ship an >>> > incomplete >>> > feature that websites might end up depending on. Once we ship a vendor >>> > prefixed >>> > API, if folks start depending on it, we need to keep supporting it. It >>> > seems safer to >>> > hide the feature until we can ship it unprefixed in this case since the >>> > feature is already >>> > well known and specified in a standard. >>> > >>> > -Darin >>> > >>> >> >>> >> >>> >> Let me know if I can answer any questions! >>> >> >>> >> -eric >>> >> _______________________________________________ >>> >> webkit-dev mailing list >>> >> webkit-dev@lists.webkit.org >>> >> <a rel="nofollow" href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a> >>> > >>> > >> >> _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org <a rel="nofollow" href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg18594.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd2.html#18954">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#18954">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg18955.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg18586.html">[webkit-dev] Feature Announcement: Adding <iframe s...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18588.html">Re: [webkit-dev] Feature Announcement: Adding <...</a></span> <span class="sender italic">Darin Fisher</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18592.html">Re: [webkit-dev] Feature Announcement: Adding...</a></span> <span class="sender italic">Alexey Proskuryakov</span></li> <li class="icons-email"><span class="subject"><a href="msg18594.html">Re: [webkit-dev] Feature Announcement: Adding...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email tSliceCur"><span class="subject">Re: [webkit-dev] Feature Announcement: Ad...</span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18955.html">Re: [webkit-dev] Feature Announcement...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18956.html">Re: [webkit-dev] Feature Announc...</a></span> <span class="sender italic">Dimitri Glazkov</span></li> <li class="icons-email"><span class="subject"><a href="msg18957.html">Re: [webkit-dev] Feature Announc...</a></span> <span class="sender italic">Eric Seidel</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18958.html">Re: [webkit-dev] Feature Ann...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg18959.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Adam Barth</span></li> <li class="icons-email"><span class="subject"><a href="msg18960.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li class="icons-email"><span class="subject"><a href="msg18963.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Jarred Nicholls</span></li> <li class="icons-email"><span class="subject"><a href="msg18967.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> <li class="icons-email"><span class="subject"><a href="msg18968.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Jarred Nicholls</span></li> <li class="icons-email"><span class="subject"><a href="msg18969.html">Re: [webkit-dev] Feature...</a></span> <span class="sender italic">Maciej Stachowiak</span></li> </ul> </ul> </ul> </ul> </ul> </ul> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="Re: [webkit-dev] Feature Announcement: Adding <iframe seamless>"> <input type="hidden" name="msgid" value="CA+bb4fkTkef0M5FEg4KkLPA=TsyxQAwdwtokk1TzMfpB7d0raQ@mail.gmail.com"> <input type="hidden" name="relpath" value="webkit-dev@lists.webkit.org/msg18954.html"> <input type="submit" value=" Eric Seidel "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-dev@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-dev"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-dev@lists.webkit.org/">webkit-dev - all messages</a></li> <li class="icons-about"><a href="/webkit-dev@lists.webkit.org/info.html">webkit-dev - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-dev@lists.webkit.org&q=subject:%22Re%5C%3A+%5C%5Bwebkit%5C-dev%5C%5D+Feature+Announcement%5C%3A+Adding+%3Ciframe+seamless%3E%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg18594.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg18955.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> <a href="#"><img src="/webkit-dev@lists.webkit.org/logo.png" alt="webkit-dev"></a> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">CA+bb4fkTkef0M5FEg4KkLPA=TsyxQAwdwtokk1TzMfpB7d0raQ@mail.gmail.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9cb334c63b96ea0a',t:'MTc3MDYzODQyNA=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>