Could you rename all these "helper" methods and programs to have more descriptive names?
None of this may not have happened if we had more semantically precise program/method names. On Mon, Apr 30, 2012 at 12:33 PM, Dirk Pranke <dpra...@chromium.org> wrote: > On Sun, Apr 29, 2012 at 6:20 PM, Maciej Stachowiak <m...@apple.com> wrote: > > > > On Apr 29, 2012, at 5:49 PM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> > >> Hi folks, > >> > >> new-run-webkit-tests seems to mess with the system color profile on > Mac, even when not running pixel tests. Historically, I believe we did this > only when running pixel tests. I noticed that this is because it launches > the LayoutTestHelper tool unconditionally, and in addition to changing the > color profile on Mac, it also changes font smoothing settings on Windows. > Does anyone know whether this work is required when running non-pixel > tests? If not, I'd like to change NRWT to only launch LayoutTestHelper in > pixel mode, and perhaps also rename LayoutTestHelper to PixelTestHelper. > > > > I went ahead assumed that this tool was never necessary for non-pixel > tests, if I'm wrong, please comment here: < > https://bugs.webkit.org/show_bug.cgi?id=81729> > > > > You're wrong :). I commented on the bug as well, but for the record > the chromium android port,at least, requires that that method be > called regardless of whether pixel tests are being run or not. I had > thought at some point that the chromium layout test helper did some > things that were needed on windows regardless of whether the pixel > tests were being run, but my memory might be failing me. > > It was always the intent that the start_helper() hook be generic. > However, that routine was written before we had a setup_test_run() > method, so it's probable that we could move all of the non-pixel logic > into that method. > > -- Dirk > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
