I don' t think devicePixelRatio() belongs in settings. It should be either be obtained from the platform code in WebCore/WebKit, or pushed in via API.
Simon On May 31, 2012, at 3:48 PM, Adam Barth wrote: > Is there any difference between Settings::devicePixelRatio [1] and > Settings::defaultDeviceScaleFactor [2] ? They appear to be used by > disjoint sets of ports. Shall we delete one in favor of the other? > > Adam > > [1] http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L478 > [2] http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L106 > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev