On Thu, Jun 7, 2012 at 12:33 PM, Ryosuke Niwa <rn...@webkit.org> wrote:
> Not if the test was padding. I'm talking about the case where you're > modifying WebCore and know that some tests are going to need rebaselines. > People have advised in the past that patch authors add failing test > expectations to TestExpectations files to avoid turning bots red. > I think this is bad advice. When I've been sheriff it seems like people who try this inevitably miss some tests and platforms anyway, get wrong expectations, etc. All this does is add more work for the submitter that is difficult to check ahead of time. We should just advise people to land and then fix (and be around on IRC/notify sheriffs about what's going on). It seems like this is what you were saying as your general statement as well. PK
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
