On Fri, Jun 15, 2012 at 9:30 AM, Darin Adler <[email protected]> wrote:
> On Jun 15, 2012, at 12:12 AM, Roland Steiner wrote: > > I made the original name change, because I honestly was entirely confused > about the meaning of "selfOnlyRef" (it's done by Node on Document, so what > is "self"? Why is it needed?) > > > A good rule of thumb, the one that I use, is that a name like this > shouldn't be changed when you still don’t understand the meaning of the > original name. Changing a name you fully understand, but find unclear, is > OK. > > I can see why “selfOnlyRef” is not clear to you, and I agree with Maciej > that “guardRef” is even less clear. We can probably come up with a better > name. For clarity, what we want is a name that means “parent only, not > including children”. > How about refAvoidingCyclesWithDescendents or refWithoutRefingDescendents? Here's the comment right above the declaration / definition of guardRef: // Nodes belonging to this document hold guard references - // these are enough to keep the document from being destroyed, but // not enough to keep it from removing its children. This allows a // node that outlives its document to still have a valid document // pointer without introducing reference cycles. - Ryosuke
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
