Hi,
The idea is good, we should catching build errors as soon as possible. But why
don't
you make the Apple's part of build-webkit to build
DRT/WTR/ImageDiff/testbrowser/...
too? I checked the bot logs and it seems that all port (Qt,GTK,Chromium,EFL)
except
Apple ports build everything in the compile-webkit step.
As far as I remember, the tools components build separately, because only
developers
(who would like to run tests) and buildbots need DRT and friends. What if adding
--developer-build / --build-tools / ... or any similar option to build-webkit
instead of master.cfg hacking?
br,
Ossy
Eric Seidel írta:
Sounds like a good idea to me. Many ports already build
DumpRenderTree, etc. as part of build-webkit. (Gtk/Qt come to mind.)
http://trac.webkit.org/browser/trunk/Tools/Scripts/build-dumprendertree#L74
On Tue, Jun 19, 2012 at 1:33 PM, Lucas Forschler <[email protected]> wrote:
Hello all,
Currently our build bots have a compile-webkit step. This step does NOT build
any of the tools used by the testers. Instead, the testers are building the
tools at execution time.
I would like to add a compile-tools step to run directly after the
compile-webkit step. The tools components would be packaged up into the
archive, and then downloaded by the test bots for execution. This will allow
us to catch any breaks in the tools in the compile phase rather than the test
phase.
I plan to add this to build.webkit.org and will send a patch out for review.
Please let me know if you have any interest or concerns in the implementation.
Thanks,
Lucas
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
