On Jun 28, 2012, at 11:57 PM, Horky Chen <[email protected]> wrote: > Hi, > > On Mac OS, if one time-out larger than 30s would be used, --time-out-ms > cannot work well. > > According to the run-webkit-tests script, custom Time-Out can be assigned for > each test case. But, unfortunately, below line in LayoutTestControllerMac.mm > blocked the setting if it is larger than 30s (waitUntilDone & notifyDone are > used): > static const CFTimeInterval waitToDumpWatchdogInterval = 30.0; > > That is hard code, and no parameter can be accepted to adjust it. There are > two time-out settings for one test case, is it possible to use common > time-out setting? > > Would you please help to double check about it?
Historically there has been absolutely no excuse to *expect* a single test take longer than 30 seconds. Such a test needs to be redesigned or broken up in to smaller tests. Thanks, ~Brady > > Best Regards! > Horky > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
