#include <~> need to appear below #include "". On Mon, Aug 13, 2012 at 1:52 PM, Koji Ishii <kojii...@gmail.com> wrote:
> I've got a style warning while preparing a patch for bug 51450: > Alphabetical sorting problem. [build/include_order] [4] > at > Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp > > Could someone please advice me if I should re-order the includes, or > ignore this warning? The 3 headers are Windows headers, separating > them (i.e., ignore style warning) looks good to me, but I'd be happy > to follow what webkit-dev says. > > #include "config.h" > #include "FontPlatformData.h" > > #include <windows.h> > #include <objidl.h> > #include <mlang.h> > > +#include "FontCache.h" > #include "HWndDC.h" > #include "PlatformSupport.h" > #include "SkTypeface_win.h" > #include "SkiaFontWin.h" > #include <wtf/StdLibExtras.h> > > Regards, > Koji > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
