Take a look at other patches that have added similar code to InternalSettings. You need to export the symbol by hand for the apple-win port as well.
Adam On Sat, Sep 8, 2012 at 4:52 PM, Sailesh Agrawal <[email protected]> wrote: > Hi all. > > I'm having trouble fixing link errors due to the following code that I added > to WebCore/testing/InternalSettings.cpp: > void InternalSettings::setUsesOverlayScrollbars(bool flag) > { > settings()->setUsesOverlayScrollbars(flag); > } > > This gives me the following link error: > 23>WebCoreTestSupport.lib(InternalSettings.obj) : error LNK2019: unresolved > external symbol "public: static void __cdecl > WebCore::Settings::setUsesOverlayScrollbars(bool)" > (?setUsesOverlayScrollbars@Settings@WebCore@@SAX_N@Z) referenced in function > "public: void __thiscall > WebCore::InternalSettings::setUsesOverlayScrollbars(bool)" > (?setUsesOverlayScrollbars@InternalSettings@WebCore@@QAEX_N@Z) > 23>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\bin\DumpRenderTree.dll : > fatal error LNK1120: 1 unresolved externals > > I tried exporting Settings::setUsesOverlayScrollbars in WebCore.exp.in but > this doesn't seem to have helped. > > Does anyone know what I'm missing? > > The full patch and error logs are here: > https://bugs.webkit.org/show_bug.cgi?id=96049 > > Thanks! > Sailesh > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo/webkit-dev > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-dev
