Last call on this ... I will be removing the files later today unless something goes awry :).
-- Dirk On Fri, Sep 21, 2012 at 3:41 PM, Dirk Pranke <dpra...@chromium.org> wrote: > Hi all, > > Now that we're on the new TestExpectations syntax, I'm planning to > remove the Skipped files (and support for them from NRWT). > > I have a change posted that will add minimal support for the syntax to > old-run-webkit-tests in https://bugs.webkit.org/show_bug.cgi?id=97276 > ; basically any file or directory listed in a TestExpectations file > will be skipped *regardless of the expectation listed*. I can make > things smarter if need be, but it's not clear to me how many people if > any are still using ORWT so the need doesn't seem to be there. Please > comment on the bug ASAP if you disagree and would like ORWT to be > smarter in this area :). > > Once that change lands, my plan is to copy all of the entries from the > existing Skipped files over into their corresponding TestExpectations > files, and then delete the Skipped files, and then delete the code > that supports the Skipped files in NRWT and ORWT. I hope to do this > early next week. > > If you have any objections, now would be a good time to speak up! > > Note that all of this is being done in the oft-requested name of > simplifying the number of different ways we have to handle failing > tests. Also, I will remind people that the new TestExpectations syntax > is a superset of the old Skipped file syntax, so there shouldn't be > any good reason to keep the old files around. However, if you know > something I don't, please mention it :). > > Thanks, > > -- Dirk _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev