On Mon, Dec 3, 2012 at 5:59 PM, Dirk Schulze <dschu...@adobe.com> wrote: > > On Dec 3, 2012, at 12:07 PM, Benjamin Poulain <benja...@webkit.org> wrote: > >> On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze <dschu...@adobe.com> wrote: >> Why does this feature have a flag at all? background-position with up to 4 >> arguments is specified with CSS3 background and borders. There are three >> major implementations with this feature. So we are just catching up. If the >> future works as expected (and we should have tests that verify it), then we >> should remove the flag completely. >> >> Sounds like good practice to me. >> >> Why _not_ start that feature with a flag then remove the flag when fully >> ready/tested??? > > Depends on the future. But for such a small patch, a new flag seems to be > overdone. I looked into the patch, and adding the flag caused more code, then > the actual feature (even if the computed style is missing). I believe we > should remove the flag ASAP. Flags are for bigger new features of features > that likely will change IMO. Both seems not to be the case for > background-position.
The computed style is there see http://trac.webkit.org/changeset/136378. I split the whole thing into two pieces to ease the review process. > > Greetings, > Dirk > >> >> Benjamin >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev -- Software Engineer @ Intel Open Source Technology Center _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
