On Dec 11, 2012, at 2:17 PM, Peter Kasting <pkast...@chromium.org> wrote:
> On Tue, Dec 11, 2012 at 2:14 PM, Oliver Hunt <oli...@apple.com> wrote: > I don't understand why anyone is _speculatively_ rolling out patches. > > You should only be rolling it out if you _know_ the patch is bad. > > Sometimes something bad happens to the tree, the sheriff doesn't know which > patch is responsible, and the change authors are not present to ask for help. > In a case like this the sheriff has to either do speculative rollouts or > leave the tree broken. > > Ideally, of course, change authors are around when something like this > happens. But maybe the bustage doesn't happen until much later, due to some > subtle/latent issue, or maybe the change author is in fact irresponsible. Or the sheriff could actually see if rolling out a patch locally fixes the problem. I'm not sure why they're considering "not testing" to be a valid behaviour for someone who is ostensibly meant to be keeping things going in the face of people who aren't testing. > > PK
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
