On Jan 9, 2013, at 5:40 PM, Simon Fraser <simon.fra...@apple.com> wrote:
> On Jan 9, 2013, at 4:52 PM, Steve Block <stevebl...@chromium.org> wrote: > >>> I'm really not sure that this set of changes is going in the right >>> direction. What's driving them; some abstract sense of purity, or >>> reducing the chances of introducing real bugs that we've seen in the past? >> Some of both. I was investigating a bug where WebCore is generating >> unexpected negative sizes. While looking into how this could happen, I >> noticed that in some cases, negative sizes result from size types >> being used to represent things that seem more like points. It seems >> like it would be good to clean this up this misuse of size types, and >> perhaps in the long term, we can avoid negative sizes altogether, >> which would help avoid these kinds of bug in the future. > > It seems like a lot of churn for relatively little gain. I'd rather our time > be focused > on areas that actually benefit users of WebKit. I agree with this concern. Another object for representing 2D vector data will cause more maintenance cost now and in the future. And I doubt that it gives a big enough benefit over defining when to use Point and Size today. Greetings, Dirk > > Simon > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev