We could reduce a bit of maintenance cost by removing all the defines. I
ran some numbers and I'm not sure we are there yet in terms of lost
productivity, even on the Chromium side. SVG adds around 20% to debug
compile times:

Linux, Z620, no goma, clean build, ninja, Debug DumpRenderTree, without
SVG: 4m05s
Linux, Z620, no goma, clean build, ninja, Debug DumpRenderTree, with SVG:
4m52s

Linux, Z620, no goma, clean build, ninja, Release DumpRenderTree, without
SVG: 3m58s
Linux, Z620, no goma, clean build, ninja, Release DumpRenderTree, with SVG:
4m36s

For Chromium developers not working on WebKit it is probably best to
continue building without SVG, even though I must warn you that you'll miss
out on the some sweet graphics.

Philip


On Fri, Jan 25, 2013 at 12:19 PM, Elliott Sprehn <espr...@chromium.org>wrote:

> Perhaps the time to remove ENABLE_SVG is in several years once many pages
> depend on it and disabling it results in a busted browser...
>
>
> On Fri, Jan 25, 2013 at 2:55 PM, Arunprasad Rajkumar <
> ararunpra...@gmail.com> wrote:
>
>> Eric, Most of the resource constraint environments(embedded systems)
>> still disables the SVG. If the define is removed code size of WebKit will
>> be increased by atleast 3 to 4M.
>>
>>
>> On 26 January 2013 01:01, <webkit-dev-requ...@lists.webkit.org> wrote:
>>
>>> This question came up in:https://bugs.webkit.org/show_bug.cgi?id=92393
>>>
>>> Do any ports still disable SVG?  Should we be removing the ENABLE_SVG
>>> defines (and potentially unifying SVG and HTML style resolve more
>>> closely)?
>>>
>>> --
>> *Arunprasad Rajkumar*
>> http://in.linkedin.com/in/ararunprasad
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to