On Thu, Jan 31, 2013 at 3:12 PM, Alexey Proskuryakov <a...@webkit.org> wrote: > > 31.01.2013, в 14:57, Dirk Pranke <dpra...@chromium.org> написал(а): > >>>>>> One thing to keep an eye on with WEBCORE_EXPORT is that it can increase >>>>>> the number of exports for each port, because it would export symbols that >>>>>> are only needed for other ports. >>>>> >>>> >>>> I'm not sure I understand the concern here. Is the idea that some >>>> ports might build WebCore as a DLL (and need exports) and others >>>> wouldn't? Or the idea that the API that is needed to be exported might >>>> vary from port to port in such a way that too many symbols for WebCore >>>> might be exported on some ports? >>> >>> The latter. >>> >>> I suspect that it's somewhat less of an issue for JavaScriptCore, because >>> its exports are mostly used from cross-platform code. >>> >> >> I see. Some concrete examples would be helpful here (to me, at least). >> What components and ports are we talking about, and what sorts of >> symbols? > > I don't have concrete examples, and I don't know how big an effect on > performance increasing the number of exports would have. It's something to > keep an eye on, not a reason to avoid trying. >
I'm not parsing your reply properly -- avoid trying what? A common EXPORT macro that is set as appropriate by each port? -- Dirk _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
