Hi Maciej, Thank you for taking the time to clearly enumerate these different tasks. It must have been a tedious effort, but I think the list is quite helpful in understanding the changes you are proposing.
1. The WTF changes seem like they could be easily protected by preprocessor macros to not impact other ports. 2. The WebCore ThreadGlobalData change sounds like it could be easily isolated at compile time to the iOS port. 3. Most of the WebCore changes involved CFNetwork/CALayer logic, neither of which (I believe) is used by the Chromium port. It sounds like the port most likely to be impacted by these changes would be Apple's own Mac port. Reading this list, I'm also curious why we would ever want to call "pthread_main_np", given the existence of isMainThread. If we were consistent about this, the iOS "one of two 'main' threads" stuff would be safely encapsulated. I like the idea of getting rid of the explicit "m_thread == currentThread()" asserts, in favor of some form of encapsulated predicate. All in all, I think these changes seem unlikely to be harmful, and will probably prompt some useful refactoring to clean a few things up. -Brent
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
