On Mar 13, 2013, at 9:48 AM, Ryosuke Niwa <[email protected]> wrote: > On Wed, Mar 13, 2013 at 9:42 AM, Simon Fraser <[email protected]> wrote: > https://bugs.webkit.org/show_bug.cgi?id=80046 (landed in > http://trac.webkit.org/changeset/114081) added internals. > setBackgroundBlurOnNode(). > > I consider this to be abuse of the Internals object. As shown by the location > of the files (Source/WebCore/testing/Internals.*), the Internals interface is > intended for testing, not adding API to toggle features in WebCore for > non-test code. > > Sorry, I don't follow. setBackgroundBlurOnNode appears to be only called in a > layout test as far as I read the patch. Where is this function called for > non-testing purposes?
Background blur (or background filters in general) are not a web-exposed feature, so it seems odd that Internals has a switch for some non-web-exposed feature that is only implemented by one port. It feels like this was something added for a UI feature in Chromium, in which case Internals isn't an appropriate way to toggle it. Simon
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
