On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams <gl...@skynav.com> wrote:
> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > >> Lately, I've encountering changesets that only add lines to >> TestExpectations and then never baseline tests for any platform. >> > > This (never rebaseline tests for any platform in that changeset) may not > be possible depending on circumstances. For example, I do my dev work on > MBP Retina, which produces different baselines than the platforms used for > mac test bots. As a result, I sometimes have no choice but to land a > changeset without a new baseline and then use garden-o-matic after-the-fact > to land a new baseline. > Then how are you verifying that your patch is correct? How are reviewers supposed to review such a patch? Uploading a rendering engine patch without first verifying that tests are still passing and new tests are generating results as expected sounds like a bad idea to me. Or do you have an alternative in mind that would work in my case? Note that > it really isn't practical for me to ask another dev to build my patch > before landing in order to provide me a new baseline that i can add to the > patch. > As I've announced on another thread, EWS now uploads actual results on Bugzilla so this shouldn't be an issue anymore. - R. Niwa
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
