On May 21, 2013, at 8:15 AM, Darin Adler <[email protected]> wrote: > >> Of course, we could always add an exception to the style checker > > The style checker rule is wrong and should be removed. It’s better to use a > platform abstraction, but a platform #ifdef is also OK.
This was something we discussed during the contributors meeting. The premise was that we should aim for having no PLATFORM() #ifdefs in non-Platform and and should instead use other macros that are more descriptive. I like that rule, but if isn't really possible, we should probably remove the check. Accessibility is a tricky one. The way it is currently written requires both cross platform and platform specific knowledge to co-exist. Looking at the base class, AccessibilityObject, it seems like there is a WebCore object (AccessibilityObject) that wraps a platform specific piece (m_wrapper, which on mac is a WebAccessibilityObjectWrapper and on GTK is a AtkObject, etc.). The way I would recommend moving forward is seeing if there is some way to abstract the platform specific piece in a C++ object that could live in platform (much like we do in other areas), and make all the WebCore code work in terms of it. -Sam
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
