Hi,
On Mon, Jul 22, 2013 at 11:17 PM, Kyounga Ra <kyounga...@gmail.com> wrote: > I'd like to add new feature for CSS nav-[dir] properties. > https://bugs.webkit.org/show_bug.cgi?id=66027 > > This feature is for > http://dev.w3.org/csswg/css3-ui/#nav-dir > On recent discussion, these nav-* properties was dropped from level 3. > http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html > > But, I need this feature. (I'm in the TV industry.) > Honestly, already implemented and have used it. > You can see my previous patch. > > At that time, I thought that this is W3C standard and we didn't need to > develop it behind a defined feature name. > Now, this property was dropped from CSS. > So, is it okay implementing this feature behind > ENABLE_CSS_DIRECTIONAL_FOCUS? > > I re-ported this feature whenever I rebase my webkit. > It's troublesome job. > > how about you > Adding "ENABLE_CSS_DIRECTIONAL_FOCUS" is not bad? > Adding new features has a big cost on the project, that is not the kind of thing we do lightly. Feature flags are there to allow ports to disable a feature before shipping a product. For example, if Apple decide adds a feature and GTK decides it is not ready for shipping, the feature can be disabled for releasing of WebKitGTK. Feature flags are not not a free pass to add code that is not shipped by any port. The important questions to add CSS-nav are: -Which browsers are shipping the feature? -Which browsers are planning to ship the feature? -Is it a mature standard (or an amazing feature) that one of the WebKit ports wants to maintain? Benjamin
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
